Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ubuntu build image #4650

Closed
wants to merge 2 commits into from
Closed

Update Ubuntu build image #4650

wants to merge 2 commits into from

Conversation

legleux
Copy link
Collaborator

@legleux legleux commented Aug 12, 2023

High Level Overview of Change

Context of Change

The DEB build wasn't linking all dependencies statically so failed to run on systems that didn't include the correct version.
The repo that apt pulls GCC from updated the version but apt was not updated so errored trying to retrieve the wrong version.
Moved some commands into scripts and updated the image used to build the packages also.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

@legleux legleux mentioned this pull request Aug 14, 2023
Closed
1 task
thejohnfreeman
thejohnfreeman approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@thejohnfreeman thejohnfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing here sticks out to me as wrong. I know part of it came from our private discussion. If it works, it works.

Aside, I always want to take an opportunity in reviews of this part of the codebase to reiterate that we should split it out into a separate codebase. Hope that's on the roadmap.

@legleux
Copy link
Collaborator Author

legleux commented Aug 14, 2023

Aside, I always want to take an opportunity in reviews of this part of the codebase to reiterate that we should split it out into a separate codebase. Hope that's on the roadmap.

Yes, on the roadmap for this quarter.

@intelliot
Copy link
Collaborator

What are some examples of systems that didn't include the correct version of gcc?

What error (verbatim) does this PR fix, and who (specifically) benefits from this PR being merged?

@legleux
Copy link
Collaborator Author

legleux commented Aug 15, 2023 •
edited
Loading

What are some examples of systems that didn't include the correct version of gcc?

Ubuntu 18 and 20 , Debian 10 and 11 and CentOS 7

What error (verbatim) does this PR fix, and who (specifically) benefits from this PR being merged?

A runtime error of a rippled built on a system with the non-default GCC then run on any of the above systems in a default state and an install time error with packages built with the old commands/image.

dpkg: dependency problems prevent configuration of rippled:
 rippled depends on libstdc++6 (>= 12); however:
  Version of libstdc++6:amd64 on system is 10.3.0-1ubuntu1~20.04.

@intelliot
Copy link
Collaborator

FYI @manojsdoshi : @legleux says this will enable us to build packages

@manojsdoshi manojsdoshi self-requested a review August 16, 2023 00:30
manojsdoshi
manojsdoshi approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intelliot intelliot added Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Build System labels Aug 16, 2023
@intelliot intelliot added this to the 1.12 milestone Aug 16, 2023
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
97cd3ab
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
ed5991a
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
c5ab36e
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
8da62d0
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
4e4b7a7
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
2447dbf
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
87d1145 
Signed-off-by: Manoj Doshi <[email protected]>
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
f870d70 
Signed-off-by: Manoj Doshi <[email protected]>
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 18, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
7cf929e 
Signed-off-by: Manoj Doshi <[email protected]>
This was referenced Aug 18, 2023
Closed
Closed
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 19, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
7d1fc77 
Signed-off-by: Manoj Doshi <[email protected]>
@manojsdoshi manojsdoshi mentioned this pull request Aug 19, 2023
Merged
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 21, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
ecc987f
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this pull request Aug 21, 2023
@legleux @manojsdoshi
Update Ubuntu build image (XRPLF#4650)
da203b2
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 22, 2023
@legleux @ckeshava
Update Ubuntu build image (XRPLF#4650)
76c2af3
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 25, 2023
@legleux @ckeshava
Update Ubuntu build image (XRPLF#4650)
4a72dab
@legleux legleux deleted the image-update branch January 17, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelliot intelliot intelliot approved these changes

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

@manojsdoshi manojsdoshi manojsdoshi approved these changes

Assignees

@manojsdoshi manojsdoshi

Labels
Build System Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
Core Ledger
Archived in project
Milestone
1.12
Development

Successfully merging this pull request may close these issues.
4 participants
@legleux @intelliot @thejohnfreeman @manojsdoshi